[GitHub] [spark] Hisoka-X commented on a diff in pull request #40984: [SPARK-43252] Rename the error class _LEGACY_ERROR_TEMP_2017 to UNRESOLVED_CUSTOM_CLASS

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #40984:
URL: https://github.com/apache/spark/pull/40984#discussion_r1184803225


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1599,6 +1599,11 @@
     },
     "sqlState" : "42703"
   },
+  "UNRESOLVED_CUSTOM_CLASS": {

Review Comment:
   I think there two different case, 1. class name is null 2. class name isn't null, but can't be resolved. The `UNRESOLVED_CUSTOM_CLASS` only suite for case 2. Case 1 should be handle before resolve class name. @MaxGekk WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org