[GitHub] [superset] zhaorui2022 commented on pull request #21724: fix(report): Capture unexpected errors in report screenshots. Fixes #21653

[GitBox <gi...@apache.org>]

zhaorui2022 commented on PR #21724:
URL: https://github.com/apache/superset/pull/21724#issuecomment-1275396629

   > good stuff, have 2 questions.
   > 
   >     1. in case of error modal, should we send the alert to owner and not to the receivers?
   >         I think two approach could both work. The reason I prefer sending it to receivers now is that even if some of the charts are broken in the screenshot, there might be other charts in the same screenshot that are valuable to the receivers.
   >     2. I think we should add 1 test case when there is error modal.
               I was thinking about that but didn't figure out a way to mock an error. It might due to my experience with any front end related code. Will try to investigate more and see if I can add a test case where it shows an error modal.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org