You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/01 01:38:03 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1632: Fix UnionArray is_null
viirya opened a new pull request, #1632:
URL: https://github.com/apache/arrow-rs/pull/1632
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1625.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#discussion_r863025398
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
I think so. For example, `ArrayData.is_null` returns false if its `null_bitmap` is `None`. These values are not changed before/after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#issuecomment-1115385645
Thank you @tustvold !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#discussion_r863025398
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
I think so. `ArrayData.is_null` returns false if its `null_bitmap` is `None`. These values are not changed before/after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#discussion_r862773914
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
Just to check, these special cases aren't necessary for correctness, but just clarity?
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
Just to check, these special cases aren't necessary for correctness, as the ArrayData lacks a validity buffer, but just clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1632: Fix UnionArray is_null
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#issuecomment-1114099111
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1632](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3315175) into [master](https://codecov.io/gh/apache/arrow-rs/commit/7d00e3c3b124bf39ad214ad08d1a1f49a4465dab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d00e3c) will **increase** coverage by `0.00%`.
> The diff coverage is `89.28%`.
> :exclamation: Current head 3315175 differs from pull request most recent head 7f03b63. Consider uploading reports for the commit 7f03b63 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1632 +/- ##
=======================================
Coverage 83.02% 83.03%
=======================================
Files 193 193
Lines 55577 55605 +28
=======================================
+ Hits 46145 46169 +24
- Misses 9432 9436 +4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/1632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `90.63% <89.28%> (-0.09%)` | :arrow_down: |
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `86.57% <0.00%> (-0.23%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (ø)` | |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1632/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.56% <0.00%> (+0.18%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d00e3c...7f03b63](https://codecov.io/gh/apache/arrow-rs/pull/1632?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org