You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:52:08 UTC
[GitHub] [incubator-doris] AshinGau opened a new pull request, #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
AshinGau opened a new pull request, #9931:
URL: https://github.com/apache/incubator-doris/pull/9931
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Keep the scale of low precision data to resolve the comparison errors caused by inconsistent accuracy:
```
Check tag 'q09' failed, line 3, DECIMAL result mismatch.
Expect cell is: 0.0395
But real is: 0.039535109
```
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1145007268
> Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors
Maybe we should change this back after the decimal v3 is completed. Because currently, the decimal type doesn't return real precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1144368477
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1144368573
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1145825543
> > > Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors
> >
> >
> > Maybe we should change this back after the decimal v3 is completed. Because currently, the decimal type doesn't return real precision.
>
> This fix was introduced for two reasons:
>
> 1. The previous fix judges whether two numbers(float & double) are equal by the threshold of relative change. However, this is a fixed value, which may not solve the accuracy problem with larger error, so the rounding method may be better.
>
> 2. Other correctness regression tests(tpch 100/1000) are prepared to be added, but the correct result sets come from other frameworks(Trino/Spark). Different frameworks cannot guarantee consistent behavior of decimal.
OK.
BTW, maybe we should make some modifications to these result sets from other frameworks as appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1144506287
Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] AshinGau commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
Posted by GitBox <gi...@apache.org>.
AshinGau commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1145722630
> > Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors
>
> Maybe we should change this back after the decimal v3 is completed. Because currently, the decimal type doesn't return real precision.
This fix was introduced for two reasons:
1. The previous fix judges whether two numbers(float & double) are equal by the threshold of relative change. However, this is a fixed value, which may not solve the accuracy problem with larger error, so the rounding method may be better.
2. Other correctness regression tests(tpch 100/1000) are prepared to be added, but the correct result sets come from other frameworks(Trino/Spark). Different frameworks cannot guarantee consistent behavior of decimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org