You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/03/18 22:38:31 UTC
Review Request 32219: Change default htb leaf qdisc to fq_codel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Bugs: MESOS-2514
https://issues.apache.org/jira/browse/MESOS-2514
Repository: mesos
Description
-------
When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp e5e6fa66e4032ffc6b128b5b6adf1d2e551b8f1f
Diff: https://reviews.apache.org/r/32219/diff/
Testing
-------
Manually started a container and fq_codel qdisc was successfully created.
Thanks,
Cong Wang
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/#review77446
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32219]
All tests passed.
- Mesos ReviewBot
On March 23, 2015, 5:29 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32219/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2514
> https://issues.apache.org/jira/browse/MESOS-2514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 7b4aac88d40e4e5dc3331cb19b647a1d872ef7e2
>
> Diff: https://reviews.apache.org/r/32219/diff/
>
>
> Testing
> -------
>
> Manually started a container and fq_codel qdisc was successfully created.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/
-----------------------------------------------------------
(Updated March 23, 2015, 5:29 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Changes
-------
Address review comments
Bugs: MESOS-2514
https://issues.apache.org/jira/browse/MESOS-2514
Repository: mesos
Description
-------
When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 7b4aac88d40e4e5dc3331cb19b647a1d872ef7e2
Diff: https://reviews.apache.org/r/32219/diff/
Testing
-------
Manually started a container and fq_codel qdisc was successfully created.
Thanks,
Cong Wang
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Jie Yu <yu...@gmail.com>.
> On March 21, 2015, 6:26 a.m., Jie Yu wrote:
> >
Also, when fq_codel starts to be available? Do we need to add a check during startup, or you think it's not necessary?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/#review77335
-----------------------------------------------------------
On March 18, 2015, 9:38 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32219/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2514
> https://issues.apache.org/jira/browse/MESOS-2514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e5e6fa66e4032ffc6b128b5b6adf1d2e551b8f1f
>
> Diff: https://reviews.apache.org/r/32219/diff/
>
>
> Testing
> -------
>
> Manually started a container and fq_codel qdisc was successfully created.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Jie Yu <yu...@gmail.com>.
> On March 21, 2015, 6:26 a.m., Jie Yu wrote:
> >
>
> Jie Yu wrote:
> Also, when fq_codel starts to be available? Do we need to add a check during startup, or you think it's not necessary?
OK, the availability of fq_codel qdisc will be checked in https://reviews.apache.org/r/31505. So I guess a TODO here is sufficient.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/#review77335
-----------------------------------------------------------
On March 23, 2015, 5:29 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32219/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2514
> https://issues.apache.org/jira/browse/MESOS-2514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 7b4aac88d40e4e5dc3331cb19b647a1d872ef7e2
>
> Diff: https://reviews.apache.org/r/32219/diff/
>
>
> Testing
> -------
>
> Manually started a container and fq_codel qdisc was successfully created.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/#review77335
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/32219/#comment125246>
This looks good to me. As we discussed, please add a comment about the fact that the rate set above is the max deque rate from the qdisc. Packets will be buffered at the qdisc and maybe dropped if the qdisc buffer is full. We choose to use fq_codel because it has a better flow management and a larger default buffer than pfifo_fast.
- Jie Yu
On March 18, 2015, 9:38 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32219/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2514
> https://issues.apache.org/jira/browse/MESOS-2514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e5e6fa66e4032ffc6b128b5b6adf1d2e551b8f1f
>
> Diff: https://reviews.apache.org/r/32219/diff/
>
>
> Testing
> -------
>
> Manually started a container and fq_codel qdisc was successfully created.
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 32219: Change default htb leaf qdisc to fq_codel
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32219/#review76958
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32219]
All tests passed.
- Mesos ReviewBot
On March 18, 2015, 9:38 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32219/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2514
> https://issues.apache.org/jira/browse/MESOS-2514
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When we enable bandwidth cap, htb is used on egress side inside containers, however, the default leaf qdisc for a htb class is still pfifo_fast, which is known to have buffer bloat. Change the default leaf qdisc to fq_codel too.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e5e6fa66e4032ffc6b128b5b6adf1d2e551b8f1f
>
> Diff: https://reviews.apache.org/r/32219/diff/
>
>
> Testing
> -------
>
> Manually started a container and fq_codel qdisc was successfully created.
>
>
> Thanks,
>
> Cong Wang
>
>