You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by zzcclp <gi...@git.apache.org> on 2018/03/09 15:41:31 UTC
[GitHub] carbondata pull request #2050: [CARBONDATA-2244]fix creating pre-aggregate t...
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/2050
[CARBONDATA-2244]fix creating pre-aggregate table bug when there are invisibility INSERT_IN_PROGRESS/INSERT_OVERWRITE_IN_PROGRESS segments on main table
When there are some invisibility INSERT_IN_PROGRESS/INSERT_OVERWRITE_IN_PROGRESS segments on main table, it can not create preaggregate table on it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? No
- [ ] Any backward compatibility impacted? No
- [ ] Document update required? No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zzcclp/carbondata CARBONDATA-2244
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2050.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2050
----
commit 7ec7df0c790f20a19a0092ab3a9f5d99ae7ea705
Author: Zhang Zhichao <44...@...>
Date: 2018-03-09T15:36:08Z
[CARBONDATA-2244]fix creating pre-aggregate table bug when there are invisibility INSERT_IN_PROGRESS/INSERT_OVERWRITE_IN_PROGRESS segments on main table
When there are some invisibility INSERT_IN_PROGRESS/INSERT_OVERWRITE_IN_PROGRESS segments on main table, it can not create preaggregate table on it.
----
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3116/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
@jackylk @ravipesala please help to review, thanks
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2959/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4170/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2050
LGTM
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2926/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4368/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2924/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4216/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4204/
---
[GitHub] carbondata pull request #2050: [CARBONDATA-2244]fix creating pre-aggregate t...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2050#discussion_r174206728
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -166,8 +166,9 @@ case class PreAggregateTableHelper(
// table.
SegmentStatusManager.deleteLoadsAndUpdateMetadata(parentTable, false)
val loadAvailable = SegmentStatusManager.readLoadMetadata(parentTable.getMetadataPath)
- if (loadAvailable.exists(load => load.getSegmentStatus == SegmentStatus.INSERT_IN_PROGRESS ||
- load.getSegmentStatus == SegmentStatus.INSERT_OVERWRITE_IN_PROGRESS)) {
+ if (loadAvailable.exists(load => load.getVisibility().equalsIgnoreCase("true") &&
--- End diff --
Please use the utility SegmentStatusManager.isLoadInProgressInTable
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2965/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3141/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest sdv please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2050
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3850/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4168/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2923/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
@jackylk @ravipesala please review, thanks
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4169/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4207/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2050
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3830/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4264/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2050
Do you encounter problem in some scenario, or just find it by review?
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2050
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3888/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
@jackylk please help to review, thanks.
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2971/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3130/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4380/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2050
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3861/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest sdv please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata pull request #2050: [CARBONDATA-2244]fix creating pre-aggregate t...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2050#discussion_r174373603
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -166,8 +166,9 @@ case class PreAggregateTableHelper(
// table.
SegmentStatusManager.deleteLoadsAndUpdateMetadata(parentTable, false)
val loadAvailable = SegmentStatusManager.readLoadMetadata(parentTable.getMetadataPath)
- if (loadAvailable.exists(load => load.getSegmentStatus == SegmentStatus.INSERT_IN_PROGRESS ||
- load.getSegmentStatus == SegmentStatus.INSERT_OVERWRITE_IN_PROGRESS)) {
+ if (loadAvailable.exists(load => load.getVisibility().equalsIgnoreCase("true") &&
--- End diff --
Done
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4213/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2050
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3863/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4198/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4171/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4350/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2962/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest sdv please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3020/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
@jackylk someone encounters this problem and ask this issue in Weixin Group.
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest this please.
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2050
retest sdv please
---
[GitHub] carbondata pull request #2050: [CARBONDATA-2244]fix creating pre-aggregate t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2050
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2922/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4167/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2968/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3147/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2925/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4211/
---
[GitHub] carbondata issue #2050: [CARBONDATA-2244]fix creating pre-aggregate table bu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2050
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2953/
---