You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/12/01 15:55:07 UTC

[GitHub] tinkerpop issue #510: TINKERPOP-1562 Migrate ScriptEngine-related code to gr...

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/510
  
    @okram one thing that could use your explict review here - we lost the ability to do wildcard imports given the work you did on `CoreImports` for gremlin-python. Some plugins used a lot of wildcards, specifically the hadoop plugin:
    
    https://github.com/apache/tinkerpop/blob/90f427c8dc11636a5884e6cca3c0a22249d26576/hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/jsr223/HadoopGremlinPlugin.java
    
    I didn't go through hadoop APIs to add all the classes that were wildcarded. can you please give a review to see if anything else should be added there?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---