You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by su...@apache.org on 2021/04/10 00:11:50 UTC
[druid] branch master updated: Update SketchAggregator.java for
removing duplicated parentheses (#11021)
This is an automated email from the ASF dual-hosted git repository.
suneet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new d939420 Update SketchAggregator.java for removing duplicated parentheses (#11021)
d939420 is described below
commit d939420f23421ac13325a14cd23b27236f095928
Author: Makdon <ma...@makdon.me>
AuthorDate: Sat Apr 10 08:11:25 2021 +0800
Update SketchAggregator.java for removing duplicated parentheses (#11021)
* Update SketchAggregator.java
* Add test for sketches aggregator update unoin with double
---
.../aggregation/datasketches/theta/SketchAggregator.java | 2 +-
.../datasketches/theta/SketchAggregationTest.java | 15 +++++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java b/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
index 9a33085..cf930bc 100644
--- a/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
+++ b/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
@@ -112,7 +112,7 @@ public class SketchAggregator implements Aggregator
} else if (update instanceof byte[]) {
union.update((byte[]) update);
} else if (update instanceof Double) {
- union.update(((Double) update));
+ union.update((Double) update);
} else if (update instanceof Integer || update instanceof Long) {
union.update(((Number) update).longValue());
} else if (update instanceof int[]) {
diff --git a/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregationTest.java b/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregationTest.java
index fe3077b..06e6287 100644
--- a/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregationTest.java
+++ b/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregationTest.java
@@ -529,6 +529,21 @@ public class SketchAggregationTest
Assert.assertEquals(2, ((SketchHolder) agg.get()).getSketch().getEstimate(), 0);
}
+ @Test
+ public void testUpdateUnionWithDouble()
+ {
+ Double[] columnValues = new Double[]{2.0};
+ final TestObjectColumnSelector selector = new TestObjectColumnSelector(columnValues);
+ final Aggregator agg = new SketchAggregator(selector, 4096);
+ agg.aggregate();
+ Assert.assertFalse(agg.isNull());
+ Assert.assertNotNull(agg.get());
+ Assert.assertTrue(agg.get() instanceof SketchHolder);
+ Assert.assertEquals(1, ((SketchHolder) agg.get()).getEstimate(), 0);
+ Assert.assertNotNull(((SketchHolder) agg.get()).getSketch());
+ Assert.assertEquals(1, ((SketchHolder) agg.get()).getSketch().getEstimate(), 0);
+ }
+
private void assertPostAggregatorSerde(PostAggregator agg) throws Exception
{
Assert.assertEquals(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org