You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by joel-hamill <gi...@git.apache.org> on 2017/12/12 19:53:19 UTC

[GitHub] kafka-site pull request #112: Migrate Streams Dev Guide content to AK

GitHub user joel-hamill opened a pull request:

    https://github.com/apache/kafka-site/pull/112

    Migrate Streams Dev Guide content to AK

    See related https://github.com/apache/kafka/pull/4252

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joel-hamill/kafka-site add-update-dev-guide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka-site/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----

----


---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

Posted by derrickdoo <gi...@git.apache.org>.

Github user derrickdoo commented on the issue:

    https://github.com/apache/kafka-site/pull/112
  
    @joel-hamill just took a look at your branch. Content looks good, but I'd suggest adding that horizontal subnav on the developer guide page for consistency and make sure users can easily jump around.
    
    Here's the page I'm looking at:
    ![image](https://user-images.githubusercontent.com/271961/34065592-185b40c8-e1b8-11e7-93a3-b93198c6053c.png)



---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

Posted by guozhangwang <gi...@git.apache.org>.

Github user guozhangwang commented on the issue:

    https://github.com/apache/kafka-site/pull/112
  
    LGTM. Merged to asf-site.


---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

Posted by joel-hamill <gi...@git.apache.org>.

Github user joel-hamill commented on the issue:

    https://github.com/apache/kafka-site/pull/112
  
    ping @guozhangwang 


---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

Posted by derrickdoo <gi...@git.apache.org>.

Github user derrickdoo commented on the issue:

    https://github.com/apache/kafka-site/pull/112
  
    👍 💯 LGTM


---

[GitHub] kafka-site pull request #112: Migrate Streams Dev Guide content to AK

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka-site/pull/112


---