[GitHub] [calcite] hsyuan commented on a change in pull request #1108: [CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1108: [CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function
URL: https://github.com/apache/calcite/pull/1108#discussion_r267194266
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/SqlOperator.java
 ##########
 @@ -234,21 +234,21 @@ public int getRightPrec() {
   public abstract SqlSyntax getSyntax();
 
   /**
-   * Creates a call to this operand with an array of operands.
-   *
-   * <p>The position of the resulting call is the union of the <code>
-   * pos</code> and the positions of all of the operands.
+   * Creates a call to this operand with an array of operands and specifying
+   * whether it ignores nulls.
    *
    * @param functionQualifier function qualifier (e.g. "DISTINCT"), may be
+   * @param ignoreNulls       Whether ignore nulls
    * @param pos               parser position of the identifier of the call
    * @param operands          array of operands
    */
   public SqlCall createCall(
       SqlLiteral functionQualifier,
+      SqlLiteral ignoreNulls,
 
 Review comment:
   This is an API-breaking change. Should add a new createCall function with `ignoreNulls` and deprecate the existing `createCall`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services