You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/09/06 03:08:39 UTC
[lucene-solr] branch reference_impl_dev updated: @756 Update flakey
test.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/reference_impl_dev by this push:
new 1d812c6 @756 Update flakey test.
1d812c6 is described below
commit 1d812c616f6d059dfb4185cb1e76a09a65fd61c1
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sat Sep 5 22:08:04 2020 -0500
@756 Update flakey test.
---
.../src/test/org/apache/solr/handler/export/TestExportWriter.java | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java b/solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java
index 4605a07..3ee0af3 100644
--- a/solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java
+++ b/solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java
@@ -728,6 +728,7 @@ public class TestExportWriter extends SolrTestCaseJ4 {
}
@Test
+ @AwaitsFix(bugUrl = "flakey, can return 99 instead of 100 results, missing 95 in results")
public void testExpr() throws Exception {
assertU(delQ("*:*"));
assertU(commit());
@@ -752,12 +753,7 @@ public class TestExportWriter extends SolrTestCaseJ4 {
List<Map<String, Object>> docs = (List<Map<String, Object>>) Utils.getObjectByPath(rspMap, false, "/response/docs");
assertNotNull("missing document results: " + rspMap, docs);
- if (docs.size() == 99) {
- // TODO: sometimes this can happen
- } else {
- assertEquals("wrong number of unique docs", 100, docs.size());
- }
-
+ assertEquals("wrong number of unique docs", 100, docs.size());
for (int i = 0; i < 99; i++) {
boolean found = false;