You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by djwatson <gi...@git.apache.org> on 2014/04/30 23:29:56 UTC
[GitHub] thrift pull request: THRIFT-2471
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/113
THRIFT-2471
three changes as discussed in THRIFT-2471:
* Update parser to use & instead of cpp.ref
* Recursion depth limit, a la protobufs
* shared_ptr instead of raw pointer w/deletes in the destructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djwatson/thrift cpp.ref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 52b99af4ee1574253dcb77933d76a7ebb2d830df
Author: Dave Watson <da...@fb.com>
Date: 2014-04-23T20:05:56Z
change cpp.ref to &
commit 3f9d31cc6140367529fd8f7b1b67056ec321786f
Author: Dave Watson <da...@fb.com>
Date: 2014-04-23T21:50:29Z
Recursion depth limit
commit 61468e4534ce9e6a4f4f643bfd00542d13600d83
Author: Dave Watson <da...@fb.com>
Date: 2014-04-25T19:59:18Z
shared_ptr for reference type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #113: THRIFT-2471
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/113
Sorry, #1195 has nothing to do with this one. I was off by one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2471
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---