You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nicolás Lichtmaier <ni...@reloco.com.ar> on 2004/04/07 15:56:27 UTC
My patches
I have submitted 3 patches:
* An update to es.po
* A fix to a time function
* Marking-up of internationalizabel strings.
Other than detailed nitpicking over spaces and fine formatting I've got
no feedback. At least reject the patches =) .
Bye!
Re: My patches
Posted by Ben Reser <be...@reser.org>.
On Wed, Apr 07, 2004 at 12:56:27PM -0300, Nicol?s_Lichtmaier wrote:
> I have submitted 3 patches:
>
> * An update to es.po
> * A fix to a time function
> * Marking-up of internationalizabel strings.
>
> Other than detailed nitpicking over spaces and fine formatting I've got
> no feedback. At least reject the patches =) .
I think there are two things going on here.
a) Nobody has had the time to really look at the time function. I
intend to but I haven't. The formatting things jumped out at me so I
said something.
b) The i18n stuff is still being debated regarding how to deal with it
to some extent. I know some committers raised issues with the way you
were doing some stuff. I'm not sure if this is fixed, because I haven't
paid a whole lot of attention to your i18n patches.
> Bye!
I hope you're just not walking away over some slowness. subversion
tends to be very careful with core code changes. Heck I'm a full
committer and I posted a patch to implement something last week. Got a
couple comments on it. But I haven't had time to look into them and to
finally commit it.
I realize that not getting responses quickly can be frustrating when
you're sending in patches. I went through this myself when I first
started sending stuff. But understand that you're not being ignored.
People are just busy. I know the CollabNet crowd has had other
priorities than subversion lately.
Also we have a Patch Manager who's role is to ensure that patches don't
get dropped. So if nothing happens with your patch it will be added to
the issue tracker.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My patches
Posted by Greg Hudson <gh...@MIT.EDU>.
On Wed, 2004-04-07 at 11:56, Nicolás Lichtmaier wrote:
> I have submitted 3 patches:
>
> * An update to es.po
> * A fix to a time function
> * Marking-up of internationalizabel strings.
>
>
> Other than detailed nitpicking over spaces and fine formatting I've
> got no feedback. At least reject the patches =) .
That's not entirely true. Phillip asked, about the time function patch:
> Subversion converts both ways, i.e., both time to string and
> string to time. Why does only one of these do UTF-8 conversion?
I didn't see an answer to this question.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: My patches
Posted by kf...@collab.net.
Nicolás Lichtmaier <ni...@reloco.com.ar> writes:
> I have submitted 3 patches:
>
> * An update to es.po
> * A fix to a time function
> * Marking-up of internationalizabel strings.
>
> Other than detailed nitpicking over spaces and fine formatting I've
> got no feedback. At least reject the patches =) .
Sorry for the delay, but things sometimes take a while. (People have
other responsibilities in addition to monitoring this list. Some of
them are even paid for those other responsibilities. :-) )
I've been meaning to look at the time function fix -- saw & responded
to the formatting review, but haven't had a chance to look at the
patch itself yet, unfortunately.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: My patches
Posted by Sander Striker <st...@apache.org>.
> From: Nicolas Lichtmaier [mailto:nick@reloco.com.ar]
> Sent: Wednesday, April 07, 2004 5:56 PM
> I have submitted 3 patches:
> An update to es.po
> A fix to a time function
> Marking-up of internationalizabel strings.
> Other than detailed nitpicking over spaces and fine formatting
> I've got no feedback. At least reject the patches =) .
This can mean multiple things:
- the patches are ok and can go in, but there is noone with a
round tuit
- the patches weren't reviewed yet
- your itch has a lower priority as another itch
In any case, patience is a virtue ;)
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org