[GitHub] [accumulo] EdColeman commented on a diff in pull request #3220: Add ondemand table state

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3220:
URL: https://github.com/apache/accumulo/pull/3220#discussion_r1122227522


##########
server/base/src/main/java/org/apache/accumulo/server/security/AuditedSecurityOperation.java:
##########
@@ -685,8 +685,8 @@ public boolean hasSystemPermission(TCredentials credentials, String user,
       "action: %s; targetTable: %s:%s";
 
   @Override
-  public boolean canOnlineOfflineTable(TCredentials credentials, TableId tableId, FateOperation op,
-      NamespaceId namespaceId) throws ThriftSecurityException {
+  public boolean canOnlineOfflineOnDemandTable(TCredentials credentials, TableId tableId,

Review Comment:
   Could these methods be combined into something like `canChangeTableState(...)` for the method name?  The permission could be a general allowed to change state and not for a specific state.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org