You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/08/13 14:01:33 UTC
Review Request 37435: LENS-351: Document db resources feature in user
guide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-351
https://issues.apache.org/jira/browse/LENS-351
Repository: lens
Description
-------
Documentation for static DB jar feature in user guide.
Diffs
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
Diff: https://reviews.apache.org/r/37435/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/#review95688
-----------------------------------------------------------
Other changes look fine.
src/site/apt/user/index.apt (line 68)
<https://reviews.apache.org/r/37435/#comment150785>
There is no requirement as such " The path has to be a path on the lens server's file system." - It can accept path from HDFS as well.
You can mention the path passed through file:// should exist on lens-server machine as of now. In future, Client can be extended to accept path from local file system and upload file accessible to server.
- Amareshwari Sriramadasu
On Aug. 17, 2015, 9:22 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37435/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 9:22 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-351
> https://issues.apache.org/jira/browse/LENS-351
>
>
> Repository: lens
>
>
> Description
> -------
>
> Documentation for static DB jar feature in user guide.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
>
> Diff: https://reviews.apache.org/r/37435/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> screenshot
> https://reviews.apache.org/media/uploaded/files/2015/08/17/b3b38d76-ac06-4bf9-9857-dd39854fb27b__Screen_Shot_2015-08-17_at_2.48.11_pm.png
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/#review95701
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 18, 2015, 7:18 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37435/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 7:18 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-351
> https://issues.apache.org/jira/browse/LENS-351
>
>
> Repository: lens
>
>
> Description
> -------
>
> Documentation for static DB jar feature in user guide.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
>
> Diff: https://reviews.apache.org/r/37435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 12:48 p.m.)
Review request for lens.
Bugs: LENS-351
https://issues.apache.org/jira/browse/LENS-351
Repository: lens
Description
-------
Documentation for static DB jar feature in user guide.
Diffs
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
Diff: https://reviews.apache.org/r/37435/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 12:47 p.m.)
Review request for lens.
Bugs: LENS-351
https://issues.apache.org/jira/browse/LENS-351
Repository: lens
Description
-------
Documentation for static DB jar feature in user guide.
Diffs (updated)
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
Diff: https://reviews.apache.org/r/37435/diff/
Testing
-------
File Attachments
----------------
screenshot
https://reviews.apache.org/media/uploaded/files/2015/08/17/b3b38d76-ac06-4bf9-9857-dd39854fb27b__Screen_Shot_2015-08-17_at_2.48.11_pm.png
Thanks,
Rajat Khandelwal
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/
-----------------------------------------------------------
(Updated Aug. 17, 2015, 2:52 p.m.)
Review request for lens.
Bugs: LENS-351
https://issues.apache.org/jira/browse/LENS-351
Repository: lens
Description
-------
Documentation for static DB jar feature in user guide.
Diffs (updated)
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
Diff: https://reviews.apache.org/r/37435/diff/
Testing
-------
File Attachments (updated)
----------------
screenshot
https://reviews.apache.org/media/uploaded/files/2015/08/17/b3b38d76-ac06-4bf9-9857-dd39854fb27b__Screen_Shot_2015-08-17_at_2.48.11_pm.png
Thanks,
Rajat Khandelwal
Re: Review Request 37435: LENS-351: Document db resources feature in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37435/#review95382
-----------------------------------------------------------
src/site/apt/user/index.apt (line 64)
<https://reviews.apache.org/r/37435/#comment150331>
Let us keep DB resources separate from session resources. Please add a seperate section for DB resources.
- Amareshwari Sriramadasu
On Aug. 13, 2015, 12:01 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37435/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 12:01 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-351
> https://issues.apache.org/jira/browse/LENS-351
>
>
> Repository: lens
>
>
> Description
> -------
>
> Documentation for static DB jar feature in user guide.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
>
> Diff: https://reviews.apache.org/r/37435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>