You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2006/04/17 20:53:26 UTC
DO NOT REPLY [Bug 39327] New: - Errors when compiling procrun for 64 bit windows systems
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
Summary: Errors when compiling procrun for 64 bit windows systems
Product: Commons
Version: unspecified
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: enhancement
Priority: P2
Component: Daemon
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: EtheredgeA@ACIWorldwide.com
When compiling procrun for 64 bit windows systems (x64, amd64, itanium) errors
and warnings are received. I suggest the following patch:
Index: apps/apsvcmgr/apsvcmgr.c
===================================================================
--- apps/apsvcmgr/apsvcmgr.c (revision 393026)
+++ apps/apsvcmgr/apsvcmgr.c (working copy)
@@ -610,10 +610,10 @@
#endif
hWndListHdr = ListView_GetHeader(hWndList);
/* Sub-class */
- ListViewWinMain = (WNDPROC)((SIZE_T)SetWindowLong(hWndList, GWL_WNDPROC,
+ ListViewWinMain = (WNDPROC)((SIZE_T)SetWindowLongPtr(hWndList, GWLP_WNDPROC,
(LONG)((SIZE_T)ListViewMainSubclass)));
- ListViewWinHead = (WNDPROC)((SIZE_T)SetWindowLong(hWndListHdr, GWL_WNDPROC,
+ ListViewWinHead = (WNDPROC)((SIZE_T)SetWindowLongPtr(hWndListHdr,
GWLP_WNDPROC,
(LONG)((SIZE_T)ListViewHeadSubclass)));
@@ -869,7 +869,7 @@
}
else {
SET_BIT_FLAG(_propertyChanged, 1);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -1019,7 +1019,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 2);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
Index: apps/prunmgr/prunmgr.c
===================================================================
--- apps/prunmgr/prunmgr.c (revision 393026)
+++ apps/prunmgr/prunmgr.c (working copy)
@@ -647,7 +647,7 @@
}
else {
SET_BIT_FLAG(_propertyChanged, 1);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -802,7 +802,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 2);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -942,7 +942,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 3);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -1075,7 +1075,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 4);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -1213,7 +1213,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 5);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
@@ -1360,7 +1360,7 @@
PropSheet_UnChanged(GetParent(hDlg), hDlg);
else {
SET_BIT_FLAG(_propertyChanged, 6);
- SetWindowLong(hDlg, DWL_MSGRESULT,
+ SetWindowLongPtr(hDlg, DWLP_MSGRESULT,
PSNRET_INVALID_NOCHANGEPAGE);
return TRUE;
}
Index: samples/cchild.c
===================================================================
--- samples/cchild.c (revision 393026)
+++ samples/cchild.c (working copy)
@@ -50,7 +50,7 @@
break;
}
- putch('\n');
+ _putch('\n');
return FALSE;
}
@@ -96,20 +96,20 @@
fflush(stdout);
fprintf(stderr, "Simple stderr message\n");
fflush(stderr);
- write(STDOUT_FILENO, STDO_MESSAGE, sizeof(STDO_MESSAGE) - 1);
- write(STDERR_FILENO, STDE_MESSAGE, sizeof(STDE_MESSAGE) - 1);
+ _write(STDOUT_FILENO, STDO_MESSAGE, sizeof(STDO_MESSAGE) - 1);
+ _write(STDERR_FILENO, STDE_MESSAGE, sizeof(STDE_MESSAGE) - 1);
if (conio) {
- cputs("Type 'Y' when finished typing keys...");
+ _cputs("Type 'Y' when finished typing keys...");
do {
- i = getch();
+ i = _getch();
i = toupper(i);
} while (i != 'Y');
- putch('\n');
+ _putch('\n');
}
if (do_echo) {
- cputs("Going to echo loop...\n");
- while ((i = read(STDIN_FILENO, buf, 256)) > 0) {
+ _cputs("Going to echo loop...\n");
+ while ((i = _read(STDIN_FILENO, buf, 256)) > 0) {
buf[i] = '\0';
fputs(buf, stdout);
if (strcmp(buf, "quit\n") == 0)
Index: src/gui.c
===================================================================
--- src/gui.c (revision 393026)
+++ src/gui.c (working copy)
@@ -530,7 +530,8 @@
LPSTR apxBrowseForFolderA(HWND hWnd, LPCSTR szTitle, LPCSTR szName)
{
BROWSEINFOA bi;
- ITEMIDLIST *il, *ir;
+ ITEMIDLIST *il;
+ LPITEMIDLIST ir;
LPMALLOC pMalloc;
CHAR szPath[MAX_PATH+1];
LPSTR rv = NULL;
@@ -545,11 +546,12 @@
bi.lParam = 0;
bi.iImage = 0;
bi.pidlRoot = il;
-
+
if ((ir = SHBrowseForFolderA(&bi)) != NULL) {
if (SHGetPathFromIDListA(ir, szPath))
rv = apxStrdupA(szPath);
}
+
if (SHGetMalloc(&pMalloc)) {
pMalloc->lpVtbl->Free(pMalloc, il);
pMalloc->lpVtbl->Release(pMalloc);
@@ -561,7 +563,8 @@
LPWSTR apxBrowseForFolderW(HWND hWnd, LPCWSTR szTitle, LPCWSTR szName)
{
BROWSEINFOW bi;
- ITEMIDLIST *il, *ir;
+ ITEMIDLIST *il;
+ LPITEMIDLIST ir;
LPMALLOC pMalloc;
WCHAR szPath[MAX_PATH+1];
LPWSTR rv = NULL;
@@ -786,7 +789,7 @@
DeleteObject(hBmp);
ListView_SetImageList(hList, _st_sel_users_il, LVSIL_SMALL);
- _st_sel_users_lvm = (WNDPROC)((SIZE_T)SetWindowLong(hList, GWL_WNDPROC,
+ _st_sel_users_lvm = (WNDPROC)((SIZE_T)SetWindowLongPtr(hList, GWLP_WNDPROC,
(LONG)((SIZE_T)__apxSelectUserCreateLvSubclass)));
}
@@ -894,7 +897,7 @@
switch (uMsg) {
case WM_INITDIALOG:
/* Set the application icon */
- SetClassLong(hDlg, GCL_HICON,
+ SetClassLongPtr(hDlg, GCLP_HICON,
(LONG)(SIZE_T)LoadIcon(_st_sys_gui.hInstance,
MAKEINTRESOURCE(IDI_MAINICON)));
apxCenterWindow(hDlg, _st_sys_gui.hMainWnd);
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From dennisl@apache.org 2007-06-09 03:23 -------
Jakarta Commons has moved from Bugzilla to JIRA. Please make any comments you
might have on this issue at:
https://issues.apache.org/jira/browse/DAEMON-76
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From EtheredgeA@ACIWorldwide.com 2006-04-17 19:13 -------
Created an attachment (id=18115)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18115&action=view)
Fixes compiler errors and warnings for 64 compilation
Sorry I put the patch in the issue. I didnt realize I could add it later.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From richard.mundell@trgrp.com 2007-06-07 08:57 -------
I've been swamped with emails (from readers of this bug) requesting the x86-64
tomcat5.exe binary and instructions. I've uploaded them as an attachment (a
zip file with the binary and instructions) which gives you everything you need
to work with Tomcat in a 64 bit environment in the meantime.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From richard.mundell@trgrp.com 2007-06-07 08:55 -------
Created an attachment (id=20322)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20322&action=view)
tomcat5.exe executable for Intel x86-86-compatible processors/operating systems
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From richard.mundell@trgrp.com 2007-06-07 08:56 -------
Created an attachment (id=20323)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20323&action=view)
Mini HOW-TO Tomcat as a service on Windows Server 2003 64-bit edition
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
bayard@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Errors when compiling |[daemon] Errors when
|procrun for 64 bit windows |compiling procrun for 64 bit
|systems |windows systems
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39327] - [daemon] Errors when compiling procrun for 64 bit windows systems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39327>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39327
------- Additional Comments From richard.mundell@trgrp.com 2006-06-02 19:41 -------
Adam has very kindly assisted me with this (by providing a compiled binary)
and I now have Tomcat 5.5.8 running as a service on Windows 2003 Standard 64-
bit edition with 8GB of heap memory allocated.
While we wait for the Tomcat/Jakarta Commons developers are adding native 64-
bit service support into the Windows Tomcat distribution I would be very happy
to assist anyone else trying to do this by providing a 64-bit copy of
the "Tomcat5.exe" (a.k.a procrun) binary and configuration tips which worked
in my Intel 64-bit environment. Just mail me at richard.mundell AT trgrp DOT
com.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org