You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Andreas Joseph Krogh <an...@officenet.no> on 2009/08/21 00:12:21 UTC
Patch making struts.action.excludePattern work as expected
Hi all.
I noticed excludePattern doesn't work as expected in 2.1.8-SNAPSHOT.
The problem is prepare.wrapRequest(request), it's called whether or not isUrlExcluded() which is not what we want. The whole point of setting the struts.action.excludePattern property is to tell Struts2 to "lay off" the matching URLs.
The thing for me is that I have Struts2 in the same webapp as other stuff, Struts-1.1 being one of them, and I *need* the multipart-request to reach the Struts-1.1 actions which resides in an URL which matches the excludePattern.
Attached is a patch fixing it, hopefully this will make it in the 2.1.8-GA.
--
Andreas Joseph Krogh <an...@officenet.no>
Senior Software Developer / CTO
------------------------+---------------------------------------------+
OfficeNet AS | The most difficult thing in the world is to |
Rosenholmveien 25 | know how to do a thing and to watch |
1414 Trollåsen | somebody else doing it wrong, without |
NORWAY | comment. |
| |
Tlf: +47 24 15 38 90 | |
Fax: +47 24 15 38 91 | |
Mobile: +47 909 56 963 | |
------------------------+---------------------------------------------+
Re: Patch making struts.action.excludePattern work as expected
Posted by Andreas Joseph Krogh <an...@officenet.no>.
On Friday 21 August 2009 12:28:44 am Musachy Barroso wrote:
> yeah that should not happen. Can you open a ticket and attach the
> patch there? Set the appropriate versions, that way we won't miss it.
Done, with patch. I associated it with "Affects Version/s: 2.1.8" as there wasn't any 2.1.8-SNAPSHOT there... It also applies to 2.1.7...
--
Andreas Joseph Krogh <an...@officenet.no>
Senior Software Developer / CTO
------------------------+---------------------------------------------+
OfficeNet AS | The most difficult thing in the world is to |
Rosenholmveien 25 | know how to do a thing and to watch |
1414 Trollåsen | somebody else doing it wrong, without |
NORWAY | comment. |
| |
Tlf: +47 24 15 38 90 | |
Fax: +47 24 15 38 91 | |
Mobile: +47 909 56 963 | |
------------------------+---------------------------------------------+
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Patch making struts.action.excludePattern work as expected
Posted by Musachy Barroso <mu...@gmail.com>.
yeah that should not happen. Can you open a ticket and attach the
patch there? Set the appropriate versions, that way we won't miss it.
musachy
On Thu, Aug 20, 2009 at 3:12 PM, Andreas Joseph
Krogh<an...@officenet.no> wrote:
> Hi all.
> I noticed excludePattern doesn't work as expected in 2.1.8-SNAPSHOT.
> The problem is prepare.wrapRequest(request), it's called whether or not isUrlExcluded() which is not what we want. The whole point of setting the struts.action.excludePattern property is to tell Struts2 to "lay off" the matching URLs.
>
> The thing for me is that I have Struts2 in the same webapp as other stuff, Struts-1.1 being one of them, and I *need* the multipart-request to reach the Struts-1.1 actions which resides in an URL which matches the excludePattern.
>
> Attached is a patch fixing it, hopefully this will make it in the 2.1.8-GA.
>
> --
> Andreas Joseph Krogh <an...@officenet.no>
> Senior Software Developer / CTO
> ------------------------+---------------------------------------------+
> OfficeNet AS | The most difficult thing in the world is to |
> Rosenholmveien 25 | know how to do a thing and to watch |
> 1414 Trollåsen | somebody else doing it wrong, without |
> NORWAY | comment. |
> | |
> Tlf: +47 24 15 38 90 | |
> Fax: +47 24 15 38 91 | |
> Mobile: +47 909 56 963 | |
> ------------------------+---------------------------------------------+
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org