You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/12 11:31:06 UTC
[GitHub] [skywalking-java] xu1009 opened a new pull request #89: support zgc
xu1009 opened a new pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Add an agent plugin to support <zgc>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<8411>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011738416
> Are you changing protocol back to old version by mistake?
no, i change GCPhrase to GCPhase follow the proto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011719472
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011754600
Could you try this Java agent(with ZGC support) in ZGC JVM, but send data to OAP without ZGC support? I want to check whether the new added `normal` phase would work and what is the result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r782997958
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/CMSGCModule.java
##########
@@ -35,4 +35,9 @@ protected String getOldGCName() {
protected String getNewGCName() {
return "ParNew";
}
+
+ @Override
+ protected String getNormalGcName() {
Review comment:
Gc should be GC, it is a short term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r783009006
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/CMSGCModule.java
##########
@@ -35,4 +35,9 @@ protected String getOldGCName() {
protected String getNewGCName() {
return "ParNew";
}
+
+ @Override
+ protected String getNormalGcName() {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #89: Support collecting metrics of ZGC
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r788892142
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/GCProvider.java
##########
@@ -62,6 +62,9 @@ private GCMetricAccessor findByBeanName(String name) {
} else if (name.equals("MarkSweepCompact")) {
// Serial collector ( -XX:+UseSerialGC )
return new SerialGCModule(beans);
+ } else if (name.indexOf("ZGC") > -1) {
+ // Serial collector ( -XX:+UseZGC )
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011728938
it seems, the test not update submodule to compile and genrate code, so it fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a change in pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r783664113
##########
File path: CHANGES.md
##########
@@ -20,6 +20,7 @@ Release Notes.
* Fix the bug that httpasyncclient-4.x-plugin puts the dirty tracing context in the connection context
* Compatible with the versions after dubbo-2.7.14
* Follow protocol grammar fix `GCPhrase -> GCPhase`.
+* Support zgc gc time and count metric collect
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011780459
Thanks, you could add a breakpoint on JVM data deserialization, and check what value it will be in older proto data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #89: Support collecting metrics of ZGC
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011740426
i get it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1010964123
<img width="1268" alt="wecom-temp-45c9bc374a0b653652ebb6999dbfd5df" src="https://user-images.githubusercontent.com/22722907/149135095-9ddb807f-9efb-4f3b-b86f-00546a2dca29.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #89: Support collecting metrics of ZGC
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r788604729
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/GCProvider.java
##########
@@ -62,6 +62,9 @@ private GCMetricAccessor findByBeanName(String name) {
} else if (name.equals("MarkSweepCompact")) {
// Serial collector ( -XX:+UseSerialGC )
return new SerialGCModule(beans);
+ } else if (name.indexOf("ZGC") > -1) {
+ // Serial collector ( -XX:+UseZGC )
Review comment:
@xu1009 can you open a PR to correct this comment?
```suggestion
// Z garbage collector ( -XX:+UseZGC )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011775560
ok, i try it In the afternoon, and feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011831428
<img width="879" alt="wecom-temp-0757b9a96491765557364a18219cf844" src="https://user-images.githubusercontent.com/22722907/149276129-42a13587-a003-495d-99ba-3d0ea2d3269b.png">
<img width="987" alt="wecom-temp-fe2d7e38e89136c139313c9a9585224d" src="https://user-images.githubusercontent.com/22722907/149276148-852ee92f-40ed-4bb9-b2e3-808cc9f4f381.png">
the enum is unknown value when deserialization, the value is still 2
last the phase not record, and ui not display
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011144573
Submodule updated through https://github.com/apache/skywalking-java/pull/90 by me. Please follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 edited a comment on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
xu1009 edited a comment on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011775560
ok, i will try it In the afternoon, and feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#discussion_r783662580
##########
File path: CHANGES.md
##########
@@ -20,6 +20,7 @@ Release Notes.
* Fix the bug that httpasyncclient-4.x-plugin puts the dirty tracing context in the connection context
* Compatible with the versions after dubbo-2.7.14
* Follow protocol grammar fix `GCPhrase -> GCPhase`.
+* Support zgc gc time and count metric collect
Review comment:
```suggestion
* Support ZGC GC time and count metric collect. (Require 9.0.0 OAP)
```
I think it is better we add this. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #89: support zgc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #89:
URL: https://github.com/apache/skywalking-java/pull/89#issuecomment-1011732137
Are you changing protocol back to old version by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org