You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 13:43:52 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `3.30%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 63.58% -3.31%
==========================================
Files 1014 486 -528
Lines 49513 29884 -19629
Branches 5077 0 -5077
==========================================
- Hits 33118 19001 -14117
+ Misses 16264 10883 -5381
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <90.68%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org