You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 07:45:23 UTC
[GitHub] [doris] englefly opened a new pull request, #11248: [feature] add rewrite rule to merge consecutive filter nodes
englefly opened a new pull request, #11248:
URL: https://github.com/apache/doris/pull/11248
# Proposed changes
this rule aims to merge consecutive filters.
For example:
logical plan tree:
project
|
filter(a>0)
|
filter(b>0)
|
scan
transformed to:
project
|
filter(a>0 and b>0)
|
scan
Issue Number: close #xxx
## Problem Summary:
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [ ] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11248: [feature] (Nereids) add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
924060929 merged PR #11248:
URL: https://github.com/apache/doris/pull/11248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11248: [feature] (Nereids) add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11248:
URL: https://github.com/apache/doris/pull/11248#issuecomment-1196790662
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11248: [feature] (Nereids) add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11248:
URL: https://github.com/apache/doris/pull/11248#discussion_r932145742
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveFilters.java:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.Optional;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project
+ * |
+ * filter(a>0)
+ * |
+ * filter(b>0)
+ * |
+ * scan
+ * transformed to:
+ * project
+ * |
+ * filter(a>0 and b>0)
+ * |
+ * scan
+ */
+public class MergeConsecutiveFilters extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalFilter(logicalFilter()).then(filter -> {
+ LogicalFilter<?> childFilter = filter.child();
+ Expression predicates = filter.getPredicates();
+ Expression childPredicates = childFilter.getPredicates();
+ Expression mergedPredicates = ExpressionUtils.and(predicates, childPredicates);
+ LogicalFilter mergedFilter = new LogicalFilter(
+ mergedPredicates,
+ Optional.empty(),
+ Optional.of(filter.getLogicalProperties()),
Review Comment:
re-use the logical properties will skip copyIn, so this transform do nothing.
I think you need
```java
return new LogicalFilter(mergedPredicates, childFilter.child());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11248: [feature] (Nereids) add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11248:
URL: https://github.com/apache/doris/pull/11248#discussion_r932145742
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveFilters.java:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.Optional;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project
+ * |
+ * filter(a>0)
+ * |
+ * filter(b>0)
+ * |
+ * scan
+ * transformed to:
+ * project
+ * |
+ * filter(a>0 and b>0)
+ * |
+ * scan
+ */
+public class MergeConsecutiveFilters extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalFilter(logicalFilter()).then(filter -> {
+ LogicalFilter<?> childFilter = filter.child();
+ Expression predicates = filter.getPredicates();
+ Expression childPredicates = childFilter.getPredicates();
+ Expression mergedPredicates = ExpressionUtils.and(predicates, childPredicates);
+ LogicalFilter mergedFilter = new LogicalFilter(
+ mergedPredicates,
+ Optional.empty(),
+ Optional.of(filter.getLogicalProperties()),
Review Comment:
re-use the logical properties is useless, I think you need
```java
return new LogicalFilter(mergedPredicates, childFilter.child());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly closed pull request #11248: [feature] add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
englefly closed pull request #11248: [feature] add rewrite rule to merge consecutive filter nodes
URL: https://github.com/apache/doris/pull/11248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11248: [feature] (Nereids) add rewrite rule to merge consecutive filter nodes
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11248:
URL: https://github.com/apache/doris/pull/11248#discussion_r932145742
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveFilters.java:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import java.util.Optional;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project
+ * |
+ * filter(a>0)
+ * |
+ * filter(b>0)
+ * |
+ * scan
+ * transformed to:
+ * project
+ * |
+ * filter(a>0 and b>0)
+ * |
+ * scan
+ */
+public class MergeConsecutiveFilters extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalFilter(logicalFilter()).then(filter -> {
+ LogicalFilter<?> childFilter = filter.child();
+ Expression predicates = filter.getPredicates();
+ Expression childPredicates = childFilter.getPredicates();
+ Expression mergedPredicates = ExpressionUtils.and(predicates, childPredicates);
+ LogicalFilter mergedFilter = new LogicalFilter(
+ mergedPredicates,
+ Optional.empty(),
+ Optional.of(filter.getLogicalProperties()),
Review Comment:
this line will skip copyIn, so this transform do nothing.
I think you need
```java
return new LogicalFilter(mergedPredicates, childFilter.child());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org