[GitHub] [doris] platoneko commented on a diff in pull request #18874: [enhancement](load) lazy-open necessary partitions when load

["platoneko (via GitHub)" <gi...@apache.org>]

platoneko commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1185878722


##########
be/src/runtime/load_channel_mgr.cpp:
##########
@@ -134,6 +134,21 @@ Status LoadChannelMgr::open(const PTabletWriterOpenRequest& params) {
     return Status::OK();
 }
 
+Status LoadChannelMgr::open_partition(const PartitionOpenRequest& params) {
+    UniqueId load_id(params.id());
+    std::shared_ptr<LoadChannel> channel;
+    auto it = _load_channels.find(load_id);
+    if (it != _load_channels.end()) {
+        channel = it->second;
+    } else {
+        std::stringstream ss;
+        ss << "unknown load id, load id=" << load_id;

Review Comment:
   No need to use stringstream here, can directly format in `Status::InternalError`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org