You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/10/23 21:56:25 UTC
[Impala-ASF-CR] Add distcc infrastructure.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4820
Change subject: Add distcc infrastructure.
......................................................................
Add distcc infrastructure.
This has been working for several months, and it it was written mainly
by Casey Ching while he was at Cloudera working on Impala.
Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
---
M .gitignore
A bin/distcc/.gitignore
A bin/distcc/README.md
A bin/distcc/distcc.sh
A bin/distcc/distcc_env.sh
5 files changed, 325 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/4820/1
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 2:
Would be good to send out an email to dev@ once this goes in
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: Add distcc infrastructure.
......................................................................
Add distcc infrastructure.
This has been working for several months, and it it was written mainly
by Casey Ching while he was at Cloudera working on Impala.
Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
---
M .gitignore
A bin/distcc/.gitignore
A bin/distcc/README.md
A bin/distcc/distcc.sh
A bin/distcc/distcc_env.sh
5 files changed, 330 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/4820/2
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 2: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/346/
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 3: Code-Review+2
Carry Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh
File bin/distcc/distcc.sh:
Line 1: #!/bin/bash
> Needs a copyright header
Done
Line 46: fi
> Should be able to get rid of this, we don't pick the linker up from PATH no
Done
http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.sh:
Line 1: # Licensed to the Apache Software Foundation (ASF) under one
> Needs a copyright header
Done
PS1, Line 44: and not fo
> Can you check if BUILD_FARM is defined and print a message? Otherwise peopl
Done
Line 131: IMPALA_USE_DISTCC=true
> All this linker stuff is irrelevant now that we're using the toolchain link
Done
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add distcc infrastructure.
......................................................................
Patch Set 1:
(6 comments)
Thanks for doing this
http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh
File bin/distcc/distcc.sh:
Line 1: #!/bin/bash
Needs a copyright header
Line 34: clang) # Assume the compilation options were setup for gcc, which would happen using
Ugh, we really should just consolidate the GCC/Clang argument handling into one place in the CMake scripts instead of adding this layer of hacks. Anyway, don't need to fix now.
Line 46: PATH="$DISTCC_ENV_DIR:$PATH"
Should be able to get rid of this, we don't pick the linker up from PATH now anyway.
http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.sh:
Line 1: # This file is intended to be sourced by a shell (zsh and bash have been tested).
Needs a copyright header
PS1, Line 44: BUILD_FARM
Can you check if BUILD_FARM is defined and print a message? Otherwise people may be confused if they run it and it breaks.
Line 131: function switch_linker {
All this linker stuff is irrelevant now that we're using the toolchain linker. Let's just delete it.
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add distcc infrastructure.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Add distcc infrastructure.
......................................................................
Add distcc infrastructure.
This has been working for several months, and it it was written mainly
by Casey Ching while he was at Cloudera working on Impala.
Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Reviewed-on: http://gerrit.cloudera.org:8080/4820
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M .gitignore
A bin/distcc/.gitignore
A bin/distcc/README.md
A bin/distcc/distcc.sh
A bin/distcc/distcc_env.sh
5 files changed, 330 insertions(+), 1 deletion(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>