[GitHub] [madlib] orhankislal commented on a change in pull request #374: DL: Validate predict input parameters

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #374: DL: Validate predict input parameters
URL: https://github.com/apache/madlib/pull/374#discussion_r278323679
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_validator.py_in
 ##########
 @@ -53,15 +178,15 @@ class FitInputValidator:
 
     def _validate_input_table(self, table):
         _assert(is_var_valid(table, self.independent_varname),
-                "model_keras error: invalid independent_varname "
-                "('{independent_varname}') for table "
+                "model_keras error: invalid independent_varname "\
 
 Review comment:
   Do we need these `\` characters? The string does not have the new line, thanks to the way python string concatenation works. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services