You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/12 06:28:04 UTC

[GitHub] [flink] wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …
URL: https://github.com/apache/flink/pull/8007#issuecomment-482454071
 
 
   Hi @sunjincheng121 , @xuefuz , @bowenli86 
   
   Regarding to the `listTables()`, I'm fine with current approach that `listTables` returns tables and views  if you all prefer it. I don't have a strong opinion on this.
   
   Regarding moving to the mailing list, my initial intention is involving more people into the discussion when we have diverging opinions on API, but it seems that we have a consensus on this now. I agree with @sunjincheng121 that if we think the API change is minor, I think it's fine to keep the discussion in PR. But I would suggest to update the FLIP according to the latest change after the pull request is merged.
   
   So, I'm +1 to merge this after Dawid's comments addressed.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services