You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/16 19:08:33 UTC
[GitHub] [incubator-druid] himanshug commented on a change in pull request
#7642: Web console - add enable/disable actions for middle manager workers
himanshug commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers
URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r284849733
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/WorkerTaskRunner.java
##########
@@ -49,4 +49,7 @@
Collection<Task> getPendingTaskPayloads();
+ void enableWorker(String host);
+
+ void disableWorker(String host);
Review comment:
from the impl of these methods it looks like they can be implemented here (or somewhere else rather than leaving those to be implemented via all Remote task runner) ... check for worker can be either done by the output of `getWorkers()` method (I understand that is a list of all workers and search would be O(n) but I wouldn't worry about that in this context, if it really becomes an issue then we can add an abstract method that just returns specific ImmutableWorkerInfo object given its name ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org