You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2022/06/22 06:55:28 UTC
[flink] 03/03: [FLINK-27972][tests] Forbid multiple state transitions
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 402ca9671e028ea008ffa6b332925116d4f317fe
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Wed Jun 15 11:30:20 2022 +0200
[FLINK-27972][tests] Forbid multiple state transitions
---
.../runtime/scheduler/adaptive/StopWithSavepointTest.java | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java
index 8738e7dfb47..1ee3f5e5194 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java
@@ -545,6 +545,9 @@ class StopWithSavepointTest {
ExecutionGraphHandler executionGraphHandler,
OperatorCoordinatorHandler operatorCoordinatorHandler,
List<ExceptionHistoryEntry> failureCollection) {
+ if (hadStateTransition) {
+ throw new IllegalStateException("Only one state transition is allowed.");
+ }
simulateTransitionToState(Canceling.class);
cancellingStateValidator.validateInput(
@@ -560,6 +563,9 @@ class StopWithSavepointTest {
OperatorCoordinatorHandler operatorCoordinatorHandler,
Duration backoffTime,
List<ExceptionHistoryEntry> failureCollection) {
+ if (hadStateTransition) {
+ throw new IllegalStateException("Only one state transition is allowed.");
+ }
simulateTransitionToState(Restarting.class);
restartingStateValidator.validateInput(
new ExecutingTest.RestartingArguments(
@@ -577,6 +583,9 @@ class StopWithSavepointTest {
OperatorCoordinatorHandler operatorCoordinatorHandler,
Throwable failureCause,
List<ExceptionHistoryEntry> failureCollection) {
+ if (hadStateTransition) {
+ throw new IllegalStateException("Only one state transition is allowed.");
+ }
simulateTransitionToState(Failing.class);
failingStateValidator.validateInput(
new ExecutingTest.FailingArguments(
@@ -593,6 +602,9 @@ class StopWithSavepointTest {
ExecutionGraphHandler executionGraphHandler,
OperatorCoordinatorHandler operatorCoordinatorHandler,
List<ExceptionHistoryEntry> failureCollection) {
+ if (hadStateTransition) {
+ throw new IllegalStateException("Only one state transition is allowed.");
+ }
simulateTransitionToState(Executing.class);
executingStateTransition.validateInput(
new ExecutingTest.CancellingArguments(