You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yp969803 (via GitHub)" <gi...@apache.org> on 2023/12/06 04:26:48 UTC
[PR] [ISSUE #7617] Changed the buffer time to 1sec in unit test testState… [rocketmq]
yp969803 opened a new pull request, #7618:
URL: https://github.com/apache/rocketmq/pull/7618
…AndRecover
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7617
### Brief Description
Change the buffer time to 1sec
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
```
mvn test
```
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… [rocketmq]
Posted by "yp969803 (via GitHub)" <gi...@apache.org>.
yp969803 commented on code in PR #7618:
URL: https://github.com/apache/rocketmq/pull/7618#discussion_r1461106290
##########
common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java:
##########
@@ -36,6 +36,6 @@ public void computeIfAbsent() {
String value2 = ConcurrentHashMapUtils.computeIfAbsent(map, "123", k -> "2342");
assertEquals("1111", value2);
// map.computeIfAbsent("AaAa", key->map.computeIfAbsent("BBBB",key2->"42"));
- ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key -> map.computeIfAbsent("BBBB", key2 -> "42"));
+ // ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key -> map.computeIfAbsent("BBBB", key2 -> "42"));
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… [rocketmq]
Posted by "yp969803 (via GitHub)" <gi...@apache.org>.
yp969803 closed pull request #7618: [ISSUE #7617] Changed the buffer time to 10sec in unit test testState…
URL: https://github.com/apache/rocketmq/pull/7618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7617] Changed the buffer time to 1sec in unit test testState… [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7618:
URL: https://github.com/apache/rocketmq/pull/7618#issuecomment-1842081978
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`c2c29c2`)](https://app.codecov.io/gh/apache/rocketmq/commit/c2c29c2435e0626cfe4f49830fbdc0d9421d82b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.20% compared to head [(`a07cf0f`)](https://app.codecov.io/gh/apache/rocketmq/pull/7618?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.22%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7618 +/- ##
=============================================
+ Coverage 43.20% 43.22% +0.02%
- Complexity 9796 9802 +6
=============================================
Files 1164 1164
Lines 84420 84420
Branches 10961 10961
=============================================
+ Hits 36474 36494 +20
+ Misses 43420 43392 -28
- Partials 4526 4534 +8
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7618?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… [rocketmq]
Posted by "joeCarf (via GitHub)" <gi...@apache.org>.
joeCarf commented on code in PR #7618:
URL: https://github.com/apache/rocketmq/pull/7618#discussion_r1460723484
##########
common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java:
##########
@@ -36,6 +36,6 @@ public void computeIfAbsent() {
String value2 = ConcurrentHashMapUtils.computeIfAbsent(map, "123", k -> "2342");
assertEquals("1111", value2);
// map.computeIfAbsent("AaAa", key->map.computeIfAbsent("BBBB",key2->"42"));
- ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key -> map.computeIfAbsent("BBBB", key2 -> "42"));
+ // ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key -> map.computeIfAbsent("BBBB", key2 -> "42"));
Review Comment:
this change is irrelevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org