[tomcat] 02/02: Remaining false positives

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit fcd87edac2e2a86108afc4781eb8be1b0388058e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Oct 16 17:15:36 2020 +0100

    Remaining false positives
---
 res/findbugs/filter-false-positives.xml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml
index d4e0b03..4c718a3 100644
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -1909,6 +1909,15 @@
     <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
   </Match>
   <Match>
+    <!-- Return values are irrelevant as exceptions should be thrown -->
+    <Class name="org.apache.catalina.webresources.TestJarContents"/>
+    <Or>
+      <Method name="testStringOutOfBoundExceptions"/>
+      <Method name="testNullPointerExceptions"/>
+    </Or>
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
+  </Match>
+  <Match>
     <!-- Use of hard-coded path is deliberate -->
     <Class name="org.apache.catalina.webresources.TestStandardRoot" />
     <Method name="&lt;clinit&gt;" />
@@ -2140,6 +2149,12 @@
     </Or>
   </Match>
   <Match>
+    <!-- Array contents is not mutated -->
+    <Class name="org.apache.tomcat.websocket.pojo.TestEncodingDecoding$MsgByte"/>
+    <Field name="data"/>
+    <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+  </Match>
+  <Match>
     <!-- Return value of latch is intentionally ignored -->
     <Or>
       <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClient"/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org