You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 15:39:29 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #23016: Use inherited 'trigger_tasks' method

ashb commented on code in PR #23016:
URL: https://github.com/apache/airflow/pull/23016#discussion_r857768244


##########
tests/executors/test_celery_executor.py:
##########
@@ -225,19 +225,19 @@ def test_retry_on_error_sending_task(self, caplog):
 
             # Test that when heartbeat is called again, task is published again to Celery Queue
             executor.heartbeat()
-            assert dict(executor.task_publish_retries) == {key: 2}
+            assert dict(executor.task_publish_retries) == {key: 1}

Review Comment:
   Why did these numbers change? Ideally this refactor shouldn't have changed anything about the behaviour, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org