You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/07/15 22:49:34 UTC
[I] Investigate performance of CASE WHEN expression [datafusion-comet]
andygrove opened a new issue, #669:
URL: https://github.com/apache/datafusion-comet/issues/669
### What is the problem the feature request solves?
Given this SQL query:
```sql
select
sum(case when ws_wholesale_cost > 10 then 1 else 0 end) as a,
sum(case when ws_wholesale_cost > 20 then 1 else 0 end) as b,
sum(case when ws_wholesale_cost > 30 then 1 else 0 end) as c
from web_sales;
```
The query time with Comet disabled is much better than when Comet is enabled.
Disabled:
```
[1.5233631134033203, 0.35130977630615234, 0.3343064785003662, 0.35425901412963867, 0.31323719024658203]
```
Enabled:
```
[2.219223737716675, 0.886965274810791, 0.8125569820404053, 0.8285551071166992, 0.7927875518798828]
```
28 of the 99 TPC-DS queries use CASE WHEN, so optimizing this could have a nice impact on overall performance of that benchmark.
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Investigate performance of CASE WHEN expression [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #669:
URL: https://github.com/apache/datafusion-comet/issues/669#issuecomment-2229563542
I have already started experimenting with some optimizations for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Investigate performance of CASE WHEN expression [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #669:
URL: https://github.com/apache/datafusion-comet/issues/669#issuecomment-2250326455
Fixed in https://github.com/apache/datafusion/issues/11484 and https://github.com/apache/datafusion-comet/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Investigate performance of CASE WHEN expression [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #669: Investigate performance of CASE WHEN expression
URL: https://github.com/apache/datafusion-comet/issues/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Investigate performance of CASE WHEN expression [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #669:
URL: https://github.com/apache/datafusion-comet/issues/669#issuecomment-2229600464
We can specialize for certain cases, such as https://github.com/apache/datafusion/issues/11484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org