You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/19 12:28:54 UTC

[PR] fix(instance): match literal search text in inventory [rocketmq-dashboard]

Loyal-Young opened a new pull request, #7076:
URL: https://github.com/apache/rocketmq-dashboard/pull/7076

   ## Summary
   
   - Escape SQL `LIKE` metacharacters in instance name, endpoint, and remark searches.
   - Apply the same behavior to both all-instance and type-filtered queries.
   - Add regressions for `%`, `_`, backslashes, and the retained type condition.
   
   Fixes #7075.
   
   ## Verification
   
   - `git diff --check` passed.
   - Java and Maven are unavailable locally. I will inspect CI results and address any failures.
   
   ## AI assistance
   
   I used AI assistance to trace the instance-list search paths and draft the bound-query regressions. I reviewed the patch and remain responsible for CI follow-up and reviewer feedback.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): match literal search text in inventory [rocketmq-dashboard]

Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #7076:
URL: https://github.com/apache/rocketmq-dashboard/pull/7076#issuecomment-6286232971

   CI update: the Frontend Build failure is the ConsumerPage.test.tsx modal refresh assertion, outside this PR's instance repository search. The same real-timer race is documented with a pending test-only fix in #5626. MybatisPlusInstanceRepositoryTest passed locally (22/22), and the four other CI jobs passed; I will recheck CI after the shared test fix lands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): match literal search text in inventory [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #7076: fix(instance): match literal search text in inventory
URL: https://github.com/apache/rocketmq-dashboard/pull/7076


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): match literal search text in inventory [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #7076:
URL: https://github.com/apache/rocketmq-dashboard/pull/7076#issuecomment-6591826485

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org