You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2007/04/17 23:50:16 UTC
[jira] Created: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Missing asserts in ProcedureInTriggerTest
-----------------------------------------
Key: DERBY-2560
URL: https://issues.apache.org/jira/browse/DERBY-2560
Project: Derby
Issue Type: Bug
Components: Test
Affects Versions: 10.3.0.0
Reporter: Knut Anders Hatlen
ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
line 258-259 and line 263-264:
//--- Check that insert successful and trigger fired.
rs = s.executeQuery("select * from t1");
line 408-410:
//--- check delete failed
rs = s.executeQuery("select * from t1");
expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
line 421-422:
//--- check trigger is not dropped
rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
line 431-432:
// -- check index is not created
rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
line 438-440:
// -- check delete failed
rs = s.executeQuery("select * from t1");
expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden reassigned DERBY-2560:
-------------------------------------
Assignee: Kathey Marsden
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Kathey Marsden
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden resolved DERBY-2560.
-----------------------------------
Resolution: Fixed
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Kathey Marsden
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489637 ]
Knut Anders Hatlen commented on DERBY-2560:
-------------------------------------------
Thanks Kathey for fixing it so quickly. I think you missed two, though:
testModifiesSql, line 275
testTriggerNegative, line 442
They both create an array with expected rows but don't call any assert method.
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Kathey Marsden
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489566 ]
Kathey Marsden commented on DERBY-2560:
---------------------------------------
Thanks Knut for the review. I will take a look at these.
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Kathey Marsden
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2560:
----------------------------------
Fix Version/s: 10.3.0.0
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Kathey Marsden
> Fix For: 10.3.0.0
>
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2560) Missing asserts in
ProcedureInTriggerTest
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-2560.
-------------------------------------
> Missing asserts in ProcedureInTriggerTest
> -----------------------------------------
>
> Key: DERBY-2560
> URL: https://issues.apache.org/jira/browse/DERBY-2560
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Kathey Marsden
> Fix For: 10.3.0.0
>
>
> ProcedureInTriggerTest sometimes executes queries without checking the results. The comments indicate that the results should have been checked.
> line 258-259 and line 263-264:
> //--- Check that insert successful and trigger fired.
> rs = s.executeQuery("select * from t1");
> line 408-410:
> //--- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
> line 421-422:
> //--- check trigger is not dropped
> rs = s.executeQuery("select count(*) from SYS.SYSTRIGGERS where triggername='TEST_TRIG'");
> line 431-432:
> // -- check index is not created
> rs = s.executeQuery("select count(*) from SYS.SYSCONGLOMERATES where CONGLOMERATENAME='IX' and ISINDEX=1");
> line 438-440:
> // -- check delete failed
> rs = s.executeQuery("select * from t1");
> expectedRows = new String[][] { {"5","two"},{"6","four"},{"8","eight"}};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.