[GitHub] [arrow] zeroshade commented on a diff in pull request #35338: GH-35337: [Go] ASAN tests fail with Go1.20+

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #35338:
URL: https://github.com/apache/arrow/pull/35338#discussion_r1177984169


##########
go/internal/hashing/hash_string.go:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build !go1.20

Review Comment:
   the Go build constraints syntax revolves around the existence of "tags" and doesn't support `<` or `>` operators, it only supports parens, `&`, `!`, and `|`. That said, all go version tags are set for all subsequent versions.  So basically `!go1.20` == `<go1.20` and `go1.20` == `>=go1.20`.
   
   So this will do the correct thing and will also exclude go1.21 and later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org