Re: [I] Epic: Ordered Set Aggregate Functions [datafusion]

["Garamda (via GitHub)" <gi...@apache.org>]

Garamda commented on issue #12824:
URL: https://github.com/apache/datafusion/issues/12824#issuecomment-2401659938

   I see. So there are 3 sub tasks, I think.
   
   1. fix the syntax of `approx_percentile_cont` and `approx_percentile_cont_with_weight` to support `WITHIN GROUP`  (#11732)
   2. fix the same functions to support `ORDER BY sort_expression`
   3. After finishing step 1 & 2, implement new functions below (since `WITHIN GROUP` & `ORDER BY` will be reused)
     - mode() WITHIN GROUP (ORDER BY sort_expression)
     - percentile_cont(fraction) WITHIN GROUP (ORDER BY sort_expression)
     - percentile_cont(fractions) WITHIN GROUP (ORDER BY sort_expression)
     - percentile_disc(fraction) WITHIN GROUP (ORDER BY sort_expression)
     - percentile_disc(fractions) WITHIN GROUP (ORDER BY sort_expression)
   
   If there is nothing that I missed, I can start from step 1.
   So I think I can make a `take` comment on #11732 and get assigned, right?
   
   (or if you want to reorganize sub tasks and make new issues for each one since it was changed into `EPIC`, I can wait.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org