You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/13 17:57:43 UTC
[GitHub] [maven-integration-testing] psiroky opened a new pull request, #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'
psiroky opened a new pull request, #233:
URL: https://github.com/apache/maven-integration-testing/pull/233
* this should be the last _big_ PR.
* these three calls are basically identical (at least with the current version of the Verifier):
```java
(1) verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", verifier.newDefaultFilterProperties() );
(2) verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", verifier.newDefaultFilterMap() );
(3) verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" ); // uses the default filter map under the hood
```
so I figured I would go with option (3) since that's the least verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] psiroky commented on pull request #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #233:
URL: https://github.com/apache/maven-integration-testing/pull/233#issuecomment-1383225452
@slawekjaranowski, @michael-o thanks for reviewing and merging this!
I know this big PRs are hard to review (lots of files, Github UI not even rendering everything, etc). My thinking was that removing deprecated calls is good way to get familiar with the code base also do something somewhat useful in the process.
That being said, I recently learned (https://twitter.com/forked_franz/status/1614191087517679624) that these kind of PRs may not be the best way to start contributing, so I will try to refrain from these big bang changes (at least until I earn some more credit from other smaller PRs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #233:
URL: https://github.com/apache/maven-integration-testing/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #233:
URL: https://github.com/apache/maven-integration-testing/pull/233#issuecomment-1383231148
> @slawekjaranowski, @michael-o thanks for reviewing and merging this!
>
> I know this big PRs are hard to review (lots of files, Github UI not even rendering everything, etc). My thinking was that removing deprecated calls is good way to get familiar with the code base also do something somewhat useful in the process.
>
> That being said, I recently learned (https://twitter.com/forked_franz/status/1614191087517679624) that these kind of PRs may not be the best way to start contributing, so I will try to refrain from these big bang changes (at least until I earn some more credit from other smaller PRs).
That tweets sounds like bullshit to me. The change you have done was big, yes, but simple and necessary anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org