You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:08:57 UTC

[GitHub] [pulsar] hansenc commented on a change in pull request #6905: [Issue #6842] feat(schema): allow for schema reader and writer registration on SchemaDefinition

hansenc commented on a change in pull request #6905:
URL: https://github.com/apache/pulsar/pull/6905#discussion_r421622975



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/JacksonJsonReader.java
##########
@@ -27,11 +27,11 @@
 import java.io.IOException;
 import java.io.InputStream;
 
-public class JsonReader<T> implements SchemaReader<T> {
+public class JacksonJsonReader<T> implements SchemaReader<T> {

Review comment:
       Can we be sure nobody is using this class (since renaming is a backward-breaking change)? (Same question for the writer.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org