You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/05/23 20:54:18 UTC
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
> > Ship It!
If we don't have any review issues pending, can some body with commit rights push this patch?
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41708
-----------------------------------------------------------
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent
console proxy support scripts from spawning multiple java processes
Posted by Jayapal Reddy Uradi <ja...@citrix.com>.
Hi Saurav,
Can you please file bug describing the issue ?
Also please update the bug-id in review request.
Thanks,
Jayapal
On 24-May-2014, at 12:24 AM, Santhosh Edukulla <sa...@citrix.com> wrote:
>
>
>> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
>>> Ship It!
>
> If we don't have any review issues pending, can some body with commit rights push this patch?
>
>
> - Santhosh
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/#review41708
> -----------------------------------------------------------
>
>
> On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20123/
>> -----------------------------------------------------------
>>
>> (Updated April 23, 2014, 9:20 a.m.)
>>
>>
>> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>>
>>
>> Diffs
>> -----
>>
>> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>> systemvm/scripts/run.sh 146d96f
>> systemvm/scripts/utils.sh PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/20123/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>>
>>
>> Thanks,
>>
>> Saurav Lahiri
>>
>>
>