You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/18 01:01:36 UTC

[GitHub] [trafficserver] maskit commented on pull request #7845: HTTP/2 Session & ConnectionState Cleanup

maskit commented on pull request #7845:
URL: https://github.com/apache/trafficserver/pull/7845#issuecomment-842744013


   I suggest making these changes below separately beforehand to make reading the diff easy a little:
   - Changing `h2_proxy_ssn->connection_state.mutex` to `h2_proxy_ssn->mutex`
   - Moving member function definitions inside class declaration to other places - it's hard to see if a function is moved, modified, or deleted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org