You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by "jsinovassin (via GitHub)" <gi...@apache.org> on 2024/08/22 13:10:23 UTC
[PR] UNOMI-846: improve log for event validation [unomi]
jsinovassin opened a new pull request, #687:
URL: https://github.com/apache/unomi/pull/687
https://issues.apache.org/jira/browse/UNOMI-846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UNOMI-846: improve log for event validation [unomi]
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on code in PR #687:
URL: https://github.com/apache/unomi/pull/687#discussion_r1799011759
##########
extensions/json-schema/services/src/main/java/org/apache/unomi/schema/impl/SchemaServiceImpl.java:
##########
@@ -226,9 +228,9 @@ private Set<ValidationError> validate(JsonNode jsonNode, JsonSchema jsonSchema)
Set<ValidationMessage> validationMessages = jsonSchema.validate(jsonNode);
if (LOGGER.isDebugEnabled() && !validationMessages.isEmpty()) {
- LOGGER.debug("Schema validation found {} errors while validating against schema: {}", validationMessages.size(), jsonSchema.getCurrentUri());
Review Comment:
`LOGGER.isDebugEnabled() `should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UNOMI-846: improve log for event validation [unomi]
Posted by "jsinovassin (via GitHub)" <gi...@apache.org>.
jsinovassin merged PR #687:
URL: https://github.com/apache/unomi/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org