You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/16 14:53:00 UTC

[jira] [Commented] (FLINK-6457) Clean up ScalarFunction and TableFunction interface

    [ https://issues.apache.org/jira/browse/FLINK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689514#comment-16689514 ] 

ASF GitHub Bot commented on FLINK-6457:
---------------------------------------

twalthr commented on issue #3880: [FLINK-6457] [table] Clean up ScalarFunction and TableFunction interface
URL: https://github.com/apache/flink/pull/3880#issuecomment-439417094
 
 
   I also agree with @fhueske. I will close this PR for now. The affected classes might be ported to Java soon anyway due to FLINK-10689.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Clean up ScalarFunction and TableFunction interface
> ---------------------------------------------------
>
>                 Key: FLINK-6457
>                 URL: https://issues.apache.org/jira/browse/FLINK-6457
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>              Labels: pull-request-available
>
> Motivation:
> Some methods in ScalarFunction and TableFunction are unnecessary, e.g toString() and getResultType in ScalarFunction
> this issue intend to clear the interface.
> Goal:
>  only methods related to `Collector` will remain in TableFunction interface, and ScalarFunction interface shall have no methods , user can choose whether to implement the `getResultType` method, which will be called by reflection, and the Flink document will have instructions for user.
> Future:
> There should be some Annotations for user to implement methods like `@Eval` for eval method, it be will in the next issue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)