You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 04:50:20 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #31764: [SPARK-34596][SPARK-34607][SQL][FOLLOWUP][TESTS][3.1] Add `PlanTest. testFallback` and use it
cloud-fan commented on a change in pull request #31764:
URL: https://github.com/apache/spark/pull/31764#discussion_r589168308
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -961,7 +961,7 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
}
test("ANSI mode: cast string to timestamp with parse error") {
- val activeConf = conf
+ val activeConf = conf.clone()
Review comment:
do we have to clone the conf here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org