[GitHub] spark pull request: [SPARK-4452][Core]Shuffle data structures can ...

[davies <gi...@git.apache.org>]

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10024#discussion_r60092037
  
    --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java ---
    @@ -130,4 +130,22 @@ protected void freePage(MemoryBlock page) {
         used -= page.size();
         taskMemoryManager.freePage(page, this);
       }
    +
    +  /**
    +   * Allocates a heap memory of `size`.
    +   */
    +  public long allocateHeapExecutionMemory(long size) {
    --- End diff --
    
    This function does not actually create any object, I'd like to call it `acquireOnHeapMemory`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org