You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2009/12/23 17:18:29 UTC

[jira] Created: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Add a ZooKeeper service to the cloud scripts
--------------------------------------------

                 Key: HADOOP-6466
                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
             Project: Hadoop Common
          Issue Type: New Feature
          Components: contrib/cloud
            Reporter: Tom White
            Assignee: Tom White


It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6466:
------------------------------

    Fix Version/s: 0.22.0

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794102#action_12794102 ] 

Steve Loughran commented on HADOOP-6466:
----------------------------------------

Are you in danger of creating a dependency loop here? 

What might be interesting is to do a downstream project, "deployment" or some witty name that handles this and the other package/release/functional testing stuff.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796802#action_12796802 ] 

Hadoop QA commented on HADOOP-6466:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12428844/HADOOP-6466.patch
  against trunk revision 895831.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/console

This message is automatically generated.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6466:
------------------------------

    Status: Patch Available  (was: Open)

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795513#action_12795513 ] 

Henry Robinson commented on HADOOP-6466:
----------------------------------------

+1 looks perfectly sane to me. ZooKeeper specifics look good. There are a couple of Python idioms that won't work with 2.4 (with statement, particularly, is not available pre 2.5), and if that's not a problem then in a couple of places I think a defaultdict (http://docs.python.org/library/collections.html#collections.defaultdict) would be more Pythonic. However, in general, looks great to me.



> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6466:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I've just committed this.

I tested this change manually, by starting and stopping a ZooKeeper cluster.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795535#action_12795535 ] 

Tom White commented on HADOOP-6466:
-----------------------------------

Thanks for the review, Henry.

If we need to target Python 2.4 (for RHEL 5 compatibility, for instance) then it should be done as a part of another issue, since there are other places in the scripts where there are Python 2.5-isms.

I'll commit this in the next few days, unless there are objections.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797070#action_12797070 ] 

Hudson commented on HADOOP-6466:
--------------------------------

Integrated in Hadoop-Common-trunk #210 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/210/])
    . Add a ZooKeeper service to the cloud scripts.


> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6466:
------------------------------

    Attachment: HADOOP-6466.patch

Patch implementing a basic ZooKeeper service.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796919#action_12796919 ] 

Hudson commented on HADOOP-6466:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #134 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/134/])
    . Add a ZooKeeper service to the cloud scripts.


> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6466) Add a ZooKeeper service to the cloud scripts

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794108#action_12794108 ] 

Tom White commented on HADOOP-6466:
-----------------------------------

> Are you in danger of creating a dependency loop here?

Not really. There is no compile-time dependency here. The scripts already run HDFS and MapReduce clusters, which are not contained in Hadoop Common. HOD does this too.

Having said that, if people think this is a problem then we can move the scripts.

> Add a ZooKeeper service to the cloud scripts
> --------------------------------------------
>
>                 Key: HADOOP-6466
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6466
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: contrib/cloud
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-6466.patch
>
>
> It would be good to add other Hadoop services to the cloud scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.