You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2011/09/13 03:51:08 UTC

[jira] [Created] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

[hbck] Does not complain about regions with startkey==endkey.
-------------------------------------------------------------

                 Key: HBASE-4378
                 URL: https://issues.apache.org/jira/browse/HBASE-4378
             Project: HBase
          Issue Type: Bug
    Affects Versions: 0.90.4
            Reporter: Jonathan Hsieh


hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Jonathan Hsieh (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh reassigned HBASE-4378:
-------------------------------------

    Assignee: Jonathan Hsieh
    
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4378:
----------------------------------

    Component/s: hbck

> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4378:
-------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Applied 0.90, 0.92, and TRUNK.  Thanks for the patch Jon.
                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131498#comment-13131498 ] 

jiraposter@reviews.apache.org commented on HBASE-4378:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2464/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

commit 0e718c83d9f2a4d45271a2a065a23cc84b0dd247
Author: Jonathan Hsieh <jo...@cloudera.com>
Date:   Thu Oct 20 02:56:55 2011 -0700

    HBASE-4378 [hbck] Does not complain about regions with startkey==endkey


This addresses bug HBASE-4378.
    https://issues.apache.org/jira/browse/HBASE-4378


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 7409c9c 
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f5be448 

Diff: https://reviews.apache.org/r/2464/diff


Testing
-------

TestHBaseFsck passes.


Thanks,

jmhsieh


                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131962#comment-13131962 ] 

Hudson commented on HBASE-4378:
-------------------------------

Integrated in HBase-TRUNK #2345 (See [https://builds.apache.org/job/HBase-TRUNK/2345/])
    HBASE-4378 [hbck] Does not complain about regions with startkey==endkey.

stack : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java

                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4378:
----------------------------------

    Attachment: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
    
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131819#comment-13131819 ] 

jiraposter@reviews.apache.org commented on HBASE-4378:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2464/#review2707
-----------------------------------------------------------

Ship it!


Looks good to me. 


src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2464/#comment6103>

    It looks like Bytes.equals can handle nulls so this should be fine.


- Michael


On 2011-10-20 10:00:20, jmhsieh wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2464/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-20 10:00:20)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  commit 0e718c83d9f2a4d45271a2a065a23cc84b0dd247
bq.  Author: Jonathan Hsieh <jo...@cloudera.com>
bq.  Date:   Thu Oct 20 02:56:55 2011 -0700
bq.  
bq.      HBASE-4378 [hbck] Does not complain about regions with startkey==endkey
bq.  
bq.  
bq.  This addresses bug HBASE-4378.
bq.      https://issues.apache.org/jira/browse/HBASE-4378
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 7409c9c 
bq.    src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f5be448 
bq.  
bq.  Diff: https://reviews.apache.org/r/2464/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  TestHBaseFsck passes.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  jmhsieh
bq.  
bq.


                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132571#comment-13132571 ] 

Hudson commented on HBASE-4378:
-------------------------------

Integrated in HBase-0.92 #75 (See [https://builds.apache.org/job/HBase-0.92/75/])
    HBASE-4378 [hbck] Does not complain about regions with startkey==endkey.

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java

                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4378) [hbck] Does not complain about regions with startkey==endkey.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4378:
----------------------------------

    Fix Version/s: 0.90.5
                   0.92.0
           Status: Patch Available  (was: Open)

Patch should apply on 0.90, 0.92 and trunk
                
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
>                 Key: HBASE-4378
>                 URL: https://issues.apache.org/jira/browse/HBASE-4378
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.92.0, 0.90.5
>
>         Attachments: 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region where startkey==endkey.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira