You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/10/24 07:41:12 UTC
[GitHub] [groovy] Goooler opened a new pull request, #1813: Cleanup build-logic
Goooler opened a new pull request, #1813:
URL: https://github.com/apache/groovy/pull/1813
Some changes addressed from #1784.
- Replace `with` with `using` https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/DependencySubstitutions.Substitution.html
- Use HTTPS links
- Optimize imports
- Remove deprecated `forUseAtConfigurationTime` call https://docs.gradle.org/current/userguide/upgrading_version_7.html#for_use_at_configuration_time_deprecation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003918031
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##########
@@ -112,7 +114,7 @@ class JarJarTask extends DefaultTask {
def manifestFile = new File(temporaryDir, 'MANIFEST.MF')
// First step is to create a repackaged jar
outputFile.parentFile.mkdirs()
- def tstamp = Date.parse('yyyy-MM-dd HH:mm', '1980-02-01 00:00').time.toString()
+ def tstamp = (new SimpleDateFormat('yyyy-MM-dd HH:mm')).parse('1980-02-01 00:00').time.toString()
Review Comment:
The original is more idiomatic Groovy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
Goooler commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003924376
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##########
@@ -112,7 +114,7 @@ class JarJarTask extends DefaultTask {
def manifestFile = new File(temporaryDir, 'MANIFEST.MF')
// First step is to create a repackaged jar
outputFile.parentFile.mkdirs()
- def tstamp = Date.parse('yyyy-MM-dd HH:mm', '1980-02-01 00:00').time.toString()
+ def tstamp = (new SimpleDateFormat('yyyy-MM-dd HH:mm')).parse('1980-02-01 00:00').time.toString()
Review Comment:
My bad, it might be a bug of IDEA, actually no deprecation on `parse`, will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert merged PR #1813:
URL: https://github.com/apache/groovy/pull/1813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1813:
URL: https://github.com/apache/groovy/pull/1813#issuecomment-1288639663
:warning: **172 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/groovy/01GG4F0EARRJ32YDD8D071JZWB?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20groovy) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
Goooler commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003923529
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy:
##########
@@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask {
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# https://www.apache.org/licenses/LICENSE-2.0
Review Comment:
So if I should revert this line?
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy:
##########
@@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask {
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# https://www.apache.org/licenses/LICENSE-2.0
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
Goooler commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003919872
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##########
@@ -112,7 +114,7 @@ class JarJarTask extends DefaultTask {
def manifestFile = new File(temporaryDir, 'MANIFEST.MF')
// First step is to create a repackaged jar
outputFile.parentFile.mkdirs()
- def tstamp = Date.parse('yyyy-MM-dd HH:mm', '1980-02-01 00:00').time.toString()
+ def tstamp = (new SimpleDateFormat('yyyy-MM-dd HH:mm')).parse('1980-02-01 00:00').time.toString()
Review Comment:
Cause `Date.parse` is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003920466
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy:
##########
@@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask {
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# https://www.apache.org/licenses/LICENSE-2.0
Review Comment:
In most places we have left "http" inside the license text. That was conservatively because that is what is actually in the license file we refer to and we didn't want to open up an even insignificantly small debatable legal point, but also waiting for tooling to catch up. I believe lots of other projects now use https in their headers and the tooling has for the most part caught up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
Goooler commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1002969353
##########
build-logic/src/main/groovy/org.apache.groovy-published-library.gradle:
##########
@@ -765,7 +767,7 @@ publishing {
licenses {
license {
name = 'The Apache Software License, Version 2.0'
- url = 'http://www.apache.org/licenses/LICENSE-2.0.txt'
+ url = 'https://www.apache.org/licenses/LICENSE-2.0.txt'
Review Comment:
If we should replace all HTTPS links for www.apache.org?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
Goooler commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003923529
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy:
##########
@@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask {
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# https://www.apache.org/licenses/LICENSE-2.0
Review Comment:
So if I should revert this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1005044467
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/ReleaseInfoGenerator.groovy:
##########
@@ -69,7 +69,7 @@ class ReleaseInfoGenerator extends DefaultTask {
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# https://www.apache.org/licenses/LICENSE-2.0
Review Comment:
Yeah, we'll no doubt probably eventually change this but we'll probably do all 5k places in one commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on PR #1813:
URL: https://github.com/apache/groovy/pull/1813#issuecomment-1291231063
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1813: Cleanup build-logic
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on code in PR #1813:
URL: https://github.com/apache/groovy/pull/1813#discussion_r1003921148
##########
build-logic/src/main/groovy/org.apache.groovy-published-library.gradle:
##########
@@ -765,7 +767,7 @@ publishing {
licenses {
license {
name = 'The Apache Software License, Version 2.0'
- url = 'http://www.apache.org/licenses/LICENSE-2.0.txt'
+ url = 'https://www.apache.org/licenses/LICENSE-2.0.txt'
Review Comment:
This should be fine. The actual license file is at (logically at least) both http and https.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org