You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/12 20:55:04 UTC
[GitHub] [pinot] snleee commented on a change in pull request #7995: Improving segment replacement/revert protocol
snleee commented on a change in pull request #7995:
URL: https://github.com/apache/pinot/pull/7995#discussion_r783436219
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##########
@@ -271,4 +276,15 @@ private void manageSegmentLineageCleanupForTable(String tableNameWithType) {
}
LOGGER.info("Segment lineage metadata clean-up is successfully processed for table: {}", tableNameWithType);
}
+
+ private boolean shouldDeleteReplacedSegments(TableConfig tableConfig, LineageEntry lineageEntry) {
Review comment:
fixed
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##########
@@ -271,4 +276,15 @@ private void manageSegmentLineageCleanupForTable(String tableNameWithType) {
}
LOGGER.info("Segment lineage metadata clean-up is successfully processed for table: {}", tableNameWithType);
}
+
+ private boolean shouldDeleteReplacedSegments(TableConfig tableConfig, LineageEntry lineageEntry) {
Review comment:
added comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org