[jira] [Commented] (CB-7499) Cordova dialogs should support BIDI text

["Andrew Grieve (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162382#comment-14162382 ] 

Andrew Grieve commented on CB-7499:
-----------------------------------

Pretty sure adding the attribute to the manifest is fine.
http://android-developers.blogspot.ca/2013/03/native-rtl-support-in-android-42.html

Users use the play store to enable the app per-language, so I don't see how this could hurt.

As for the <engine> tag, I don't think we should add it. This is more like progressive enhancement since it's 4.2+

Bigger question is whether the plugins should check the android version before calling setTextDirection() since it was added in level 17 (almost certainly it should) Mike, can you add this?

> Cordova dialogs should support BIDI text
> ----------------------------------------
>
>                 Key: CB-7499
>                 URL: https://issues.apache.org/jira/browse/CB-7499
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>    Affects Versions: Master
>            Reporter: Mike Billau
>            Assignee: Mike Billau
>            Priority: Minor
>              Labels: bidirectional, globalization
>             Fix For: 3.7.0
>
>
> Since API 19, Andorid has had the facilities to deal with bidirectional text, however, current Cordova notification implementation does not correctly handle bidirectional text in dialogs.
> We can see this is the case by first setting the language to Hebrew and then launching the following dialogs:
>     navigator.notification.confirm("Pure English !!!", function(){}, "7"); 
>     navigator.notification.confirm("עברית היא שפה מדוברת בIsrael !", function(){}, "8");
> Since we are in Hebrew, the base text direction will be RTL. This means that when we see the second notification with the Hebrew text, it will be right-justified. When we click and see the "Pure English !!!" notication, because locale is RTL, we should expect to see: "!!! Pure English" and it should be right-justified, however, we still see "Pure English !!!", left justified.
> http://w3-03.ibm.com/globalization/page/publish/4353
> Ideally you should be able to just add   android:supportsRtl="true" to the manifest, however, this is doesn't seem to ne enough without setting the text direction to the locale for all of the dialogs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org