[jira] Commented: (NUTCH-420) DeleteDuplicates.HashPartitioner depends on the order of IndexDocs

["Dogacan Güney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462173 ] 

Dogacan Güney commented on NUTCH-420:
-------------------------------------

I realized that my last patch if's some irrevelant LOG.debug code. Attaching new version that doesn't do that.

Also the bug is in DeleteDuplicates.HashReducer not HashPartitioner (I can't believe I wrote that wrong, twice). So if there are n documents with same content, dedup may not delete them in _HashReducer_ .

> DeleteDuplicates.HashPartitioner depends on the order of IndexDocs
> ------------------------------------------------------------------
>
>                 Key: NUTCH-420
>                 URL: https://issues.apache.org/jira/browse/NUTCH-420
>             Project: Nutch
>          Issue Type: Bug
>          Components: indexer
>    Affects Versions: 0.9.0
>            Reporter: Dogacan Güney
>            Priority: Minor
>         Attachments: dedup-v2.patch, dedup.patch
>
>
> DeleteDuplicates.HashPartitioner.reduce():
> // byScore case
> if (value.score > highest.score) {
>   highest.keep = false;
>   LOG.debug("-discard " + highest + ", keep " + value);
>   output.collect(highest.url, highest);     // delete highest
>   highest = value;
> }
> // !byScore is also similar
> So assume two docs with same hash are in values.If the first has higher score than the second than second doc will be deleted. But if the first has lower score than the second then none will be deleted. AFAICS, there should be an else condition to delete value and keep highest as it is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira