[GitHub] [superset] pkdotson commented on pull request #19598: feat: add empty states to sqlab editor and select

[GitBox <gi...@apache.org>]

pkdotson commented on PR #19598:
URL: https://github.com/apache/superset/pull/19598#issuecomment-1095386179

   > @pkdotson The `DatabaseSelector` is a generic component meant to be used by multiple modules. That's why it's inside `src/components`. You shouldn't add SQL Lab specific logic inside this component like you're doing when interacting with Redux. All this logic should be encapsulated in a SQL Lab component that uses the `DatabaseSelector` and pass a `notFoundContent` property when applicable.
   
   But this component is only being used in Sqllab and used in changing the database. It makes sense for the action to happen here as this where that action is happening.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org