[GitHub] [ignite] nizhikov commented on a change in pull request #9345: IGNITE-15117 CDC for in-memory caches

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #9345:
URL: https://github.com/apache/ignite/pull/9345#discussion_r803345674



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/cdc/SqlCdcTest.java
##########
@@ -55,14 +60,31 @@
     /** */
     public static final String MSK = "Moscow";
 
+    /** */
+    @Parameterized.Parameter
+    public boolean persistenceEnabled;
+
+    /** */
+    @Parameterized.Parameters(name = "persistence={0}")
+    public static Collection<?> parameters() {
+        List<Object[]> params = new ArrayList<>();
+
+        for (boolean persistenceEnabled : new boolean[] {true, false})
+            params.add(new Object[] {persistenceEnabled});
+
+        return params;
+    }
+
+
     /** {@inheritDoc} */
     @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
         IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
 
         cfg.setDataStorageConfiguration(new DataStorageConfiguration()
-            .setCdcEnabled(true)
             .setWalForceArchiveTimeout(WAL_ARCHIVE_TIMEOUT)
-            .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(true)));
+            .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
+                .setPersistenceEnabled(true)

Review comment:
       Yes. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org